2009/05/20 - Apache Shale has been retired.

For more information, please explore the Attic.

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.0.0

Threshold is Low

Effort is Default

Files

org.apache.shale.test.mock.MockServletContext

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockServletContext.getResourcePaths(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION303
Method org.apache.shale.test.mock.MockServletContext.getResourceAsStream(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caughtSTYLEREC_CATCH_EXCEPTION263

org.apache.shale.test.mock.MockRequestMap

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockRequestMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR188

org.apache.shale.test.mock.MockPortletContext

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockPortletContext.getResourcePaths(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION267
Method org.apache.shale.test.mock.MockPortletContext.getResourceAsStream(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caughtSTYLEREC_CATCH_EXCEPTION226

org.apache.shale.test.mock.MockApplicationMap

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockApplicationMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR186

org.apache.shale.test.mock.MockMethodBinding

BugCategoryDetailsLine
org.apache.shale.test.mock.MockMethodBinding.<init>(javax.faces.application.Application,String,Class[]) may expose internal representation by storing an externally mutable object into org.apache.shale.test.mock.MockMethodBinding.argsMALICIOUS_CODEEI_EXPOSE_REP267
Comparison of String objects using == or != in org.apache.shale.test.mock.MockMethodBinding.equals(Object) CORRECTNESSES_COMPARING_STRINGS_WITH_EQ201

org.apache.shale.test.mock.MockSessionMap

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockSessionMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR189

org.apache.shale.test.el.FacesResourceBundleELResolver

BugCategoryDetailsLine
Dead store to value in method org.apache.shale.test.el.FacesResourceBundleELResolver.getFeatureDescriptors(javax.el.ELContext,Object)STYLEDLS_DEAD_LOCAL_STORE84

org.apache.shale.test.el.FacesPropertyResolverChainWrapper

BugCategoryDetailsLine
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.getType(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE86
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.getValue(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE127
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.isReadOnly(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE167
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.setValue(javax.el.ELContext,Object,Object,Object)STYLEDLS_DEAD_LOCAL_STORE209

org.apache.shale.test.el.MockVariableValueExpression

BugCategoryDetailsLine
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockVariableValueExpression.equals(Object)CORRECTNESSNS_NON_SHORT_CIRCUIT83

org.apache.shale.test.el.FacesVariableResolverChainWrapper

BugCategoryDetailsLine
Dead store to elContext in method org.apache.shale.test.el.FacesVariableResolverChainWrapper.getValue(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE110
Dead store to econtext in method org.apache.shale.test.el.FacesVariableResolverChainWrapper.getValue(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE106

org.apache.shale.test.el.FacesImplicitObjectELResolver

BugCategoryDetailsLine
Dead store to fcontext in method org.apache.shale.test.el.FacesImplicitObjectELResolver.getFeatureDescriptors(javax.el.ELContext,Object)STYLEDLS_DEAD_LOCAL_STORE99

org.apache.shale.test.el.MockValueExpression

BugCategoryDetailsLine
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockValueExpression.equals(Object)CORRECTNESSNS_NON_SHORT_CIRCUIT98

org.apache.shale.test.el.MockMethodExpression

BugCategoryDetailsLine
org.apache.shale.test.el.MockMethodExpression.<init>(String,Class[],Class) may expose internal representation by storing an externally mutable object into org.apache.shale.test.el.MockMethodExpression.signatureMALICIOUS_CODEEI_EXPOSE_REP258
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockMethodExpression.equals(Object)CORRECTNESSNS_NON_SHORT_CIRCUIT103

org.apache.shale.test.jmock.AbstractJmockJsfTestCase

BugCategoryDetailsLine
org.apache.shale.test.jmock.AbstractJmockJsfTestCase.setUp() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged blockCORRECTNESSDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEDGED93

org.apache.shale.test.base.AbstractJsfTestCase

BugCategoryDetailsLine
org.apache.shale.test.base.AbstractJsfTestCase.setUp() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged blockCORRECTNESSDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEDGED100

org.apache.shale.test.cargo.CargoTestSetup

BugCategoryDetailsLine
Confusing to have methods org.apache.shale.test.mock.MockHttpServletResponse.encodeUrl(String) and org.apache.shale.test.mock.MockPortletResponse.encodeURL(String)CORRECTNESSNM_CONFUSING194
Field not initialized in constructor: org.apache.shale.test.cargo.CargoTestSetup.containerSTYLEUWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTORNot available
Field only ever set to null: org.apache.shale.test.mock.MockPortletRequest.contextPathCORRECTNESSUWF_NULL_FIELDNot available
Should org.apache.shale.test.config.ConfigParser$ComponentBean be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available
Should org.apache.shale.test.config.ConfigParser$ConverterBean be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available
Should org.apache.shale.test.config.ConfigParser$RenderKitIdRule be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available
Should org.apache.shale.test.config.ConfigParser$RenderKitRule be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available
Should org.apache.shale.test.config.ConfigParser$RendererBean be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available
Should org.apache.shale.test.config.ConfigParser$ValidatorBean be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available
Should org.apache.shale.test.mock.MockExternalContext$LocalesIterator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available
Unread field: org.apache.shale.test.mock.MockFacesContext.lifecyclePERFORMANCEURF_UNREAD_FIELDNot available
Unread field: org.apache.shale.test.mock.MockMethodBinding.applicationPERFORMANCEURF_UNREAD_FIELDNot available
The class org.apache.shale.test.mock.MockRenderKit$1 could be refactored into a named _static_ inner classPERFORMANCESIC_INNER_SHOULD_BE_STATIC_ANONNot available