2009/05/20 - Apache Shale has been retired.

For more information, please explore the Attic.

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.0.0

Threshold is Low

Effort is Default

Files

org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfoIterator

BugCategoryDetailsLine
org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfoIterator.next() can't throw NoSuchElement exceptionCORRECTNESSIT_NO_SUCH_ELEMENT587-592

org.apache.shale.usecases.rolodex.GenericComparator

BugCategoryDetailsLine
org.apache.shale.usecases.rolodex.GenericComparator implements Comparator but not SerializableSTYLESE_COMPARATOR_SHOULD_BE_SERIALIZABLENot available
Possible null pointer dereference in org.apache.shale.usecases.rolodex.GenericComparator.compare(Object,Object)CORRECTNESSNP_NULL_ON_SOME_PATH149

org.apache.shale.usecases.rolodex.HeaderSorterRenderer

BugCategoryDetailsLine
org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(javax.faces.context.FacesContext,javax.faces.component.UIData,HeaderSorter) might ignore java.lang.ExceptionCORRECTNESSDE_MIGHT_IGNORE122
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to class org.apache.shale.usecases.rolodex.HeaderSorter in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeBegin(javax.faces.context.FacesContext,javax.faces.component.UIComponent)STYLEBC_UNCONFIRMED_CAST157
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to class org.apache.shale.usecases.rolodex.HeaderSorter in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeEnd(javax.faces.context.FacesContext,javax.faces.component.UIComponent)STYLEBC_UNCONFIRMED_CAST210

org.apache.shale.usecases.rolodex.HeaderSorter

BugCategoryDetailsLine
org.apache.shale.usecases.rolodex.HeaderSorter.saveState(javax.faces.context.FacesContext) invokes dubious Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR80

org.apache.shale.usecases.rolodex.Contact

BugCategoryDetailsLine
Method org.apache.shale.usecases.rolodex.Contact.getSortName() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version insteadI18NDM_CONVERT_CASE169

org.apache.shale.usecases.rolodex.RolodexDao$1

BugCategoryDetailsLine
Uncallable method org.apache.shale.usecases.rolodex.RolodexDao$1.addState(State) defined in anonymous classCORRECTNESSUMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS183-201
Uncallable method org.apache.shale.usecases.rolodex.RolodexDao$1.addContact(Contact) defined in anonymous classCORRECTNESSUMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS204-205

org.apache.shale.usecases.rolodex.RolodexDao

BugCategoryDetailsLine
Questionable cast from Collection to abstract class java.util.SortedSet in org.apache.shale.usecases.rolodex.RolodexDao.findContactsForTab(int)STYLEBC_BAD_CAST_TO_ABSTRACT_COLLECTION153
Questionable cast from java.util.Collection to concrete class java.util.TreeSet in org.apache.shale.usecases.rolodex.RolodexDao.findContact(String)STYLEBC_BAD_CAST_TO_CONCRETE_COLLECTION330
org.apache.shale.usecases.rolodex.GenericComparator.log isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL48
org.apache.shale.usecases.rolodex.RolodexDao.TAB_INDEX should be package protectedMALICIOUS_CODEMS_PKGPROTECT77
Should org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfo be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available