2009/05/20 - Apache Shale has been retired.

For more information, please explore the Attic.

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.1.1

Threshold is Low

Effort is Default

Summary

ClassesBugsErrorsMissing Classes
405283073

Files

ClassBugs
org.apache.shale.test.base.AbstractJsfTestCase1
org.apache.shale.test.cargo.CargoTestSetup1
org.apache.shale.test.el.FacesImplicitObjectELResolver1
org.apache.shale.test.el.FacesPropertyResolverChainWrapper4
org.apache.shale.test.el.FacesResourceBundleELResolver1
org.apache.shale.test.el.FacesVariableResolverChainWrapper2
org.apache.shale.test.el.MockMethodExpression2
org.apache.shale.test.el.MockValueExpression1
org.apache.shale.test.el.MockVariableValueExpression1
org.apache.shale.test.jmock.AbstractJmockJsfTestCase1
org.apache.shale.test.mock.MockApplication121
org.apache.shale.test.mock.MockApplicationMap1
org.apache.shale.test.mock.MockExternalContext$LocalesIterator1
org.apache.shale.test.mock.MockFacesContext1
org.apache.shale.test.mock.MockMethodBinding3
org.apache.shale.test.mock.MockRenderKit$11
org.apache.shale.test.mock.MockRequestMap1
org.apache.shale.test.mock.MockServletContext2
org.apache.shale.test.mock.MockSessionMap1
org.apache.shale.test.mock.MockValueBinding1

org.apache.shale.test.base.AbstractJsfTestCase

BugCategoryDetailsLine
org.apache.shale.test.base.AbstractJsfTestCase.setUp() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged blockBAD_PRACTICEDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED100

org.apache.shale.test.cargo.CargoTestSetup

BugCategoryDetailsLine
Field not initialized in constructor: org.apache.shale.test.cargo.CargoTestSetup.containerSTYLEUWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTORNot available

org.apache.shale.test.el.FacesImplicitObjectELResolver

BugCategoryDetailsLine
Dead store to fcontext in method org.apache.shale.test.el.FacesImplicitObjectELResolver.getFeatureDescriptors(javax.el.ELContext,Object)STYLEDLS_DEAD_LOCAL_STORE99

org.apache.shale.test.el.FacesPropertyResolverChainWrapper

BugCategoryDetailsLine
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.getType(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE86
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.getValue(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE127
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.isReadOnly(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE167
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.setValue(javax.el.ELContext,Object,Object,Object)STYLEDLS_DEAD_LOCAL_STORE209

org.apache.shale.test.el.FacesResourceBundleELResolver

BugCategoryDetailsLine
Dead store to value in method org.apache.shale.test.el.FacesResourceBundleELResolver.getFeatureDescriptors(javax.el.ELContext,Object)STYLEDLS_DEAD_LOCAL_STORE84

org.apache.shale.test.el.FacesVariableResolverChainWrapper

BugCategoryDetailsLine
Dead store to econtext in method org.apache.shale.test.el.FacesVariableResolverChainWrapper.getValue(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE106
Dead store to elContext in method org.apache.shale.test.el.FacesVariableResolverChainWrapper.getValue(javax.el.ELContext,Object,Object)STYLEDLS_DEAD_LOCAL_STORE110

org.apache.shale.test.el.MockMethodExpression

BugCategoryDetailsLine
org.apache.shale.test.el.MockMethodExpression.MockMethodExpression(String,Class[],Class) may expose internal representation by storing an externally mutable object into org.apache.shale.test.el.MockMethodExpression.signatureMALICIOUS_CODEEI_EXPOSE_REP258
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockMethodExpression.equals(Object)CORRECTNESSNS_NON_SHORT_CIRCUIT103

org.apache.shale.test.el.MockValueExpression

BugCategoryDetailsLine
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockValueExpression.equals(Object)CORRECTNESSNS_NON_SHORT_CIRCUIT98

org.apache.shale.test.el.MockVariableValueExpression

BugCategoryDetailsLine
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockVariableValueExpression.equals(Object)CORRECTNESSNS_NON_SHORT_CIRCUIT83

org.apache.shale.test.jmock.AbstractJmockJsfTestCase

BugCategoryDetailsLine
org.apache.shale.test.jmock.AbstractJmockJsfTestCase.setUp() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged blockBAD_PRACTICEDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED93

org.apache.shale.test.mock.MockApplication12

BugCategoryDetailsLine
Load of known null value in org.apache.shale.test.mock.MockApplication12.addELResolver(javax.el.ELResolver)STYLENP_LOAD_OF_KNOWN_NULL_VALUE154

org.apache.shale.test.mock.MockApplicationMap

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockApplicationMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR186

org.apache.shale.test.mock.MockExternalContext$LocalesIterator

BugCategoryDetailsLine
Should org.apache.shale.test.mock.MockExternalContext$LocalesIterator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available

org.apache.shale.test.mock.MockFacesContext

BugCategoryDetailsLine
Unread field: org.apache.shale.test.mock.MockFacesContext.lifecyclePERFORMANCEURF_UNREAD_FIELDNot available

org.apache.shale.test.mock.MockMethodBinding

BugCategoryDetailsLine
org.apache.shale.test.mock.MockMethodBinding.MockMethodBinding(javax.faces.application.Application,String,Class[]) may expose internal representation by storing an externally mutable object into org.apache.shale.test.mock.MockMethodBinding.argsMALICIOUS_CODEEI_EXPOSE_REP267
Comparison of String objects using == or != in org.apache.shale.test.mock.MockMethodBinding.equals(Object) BAD_PRACTICEES_COMPARING_STRINGS_WITH_EQ201
Unread field: org.apache.shale.test.mock.MockMethodBinding.applicationPERFORMANCEURF_UNREAD_FIELDNot available

org.apache.shale.test.mock.MockRenderKit$1

BugCategoryDetailsLine
The class org.apache.shale.test.mock.MockRenderKit$1 could be refactored into a named _static_ inner classPERFORMANCESIC_INNER_SHOULD_BE_STATIC_ANONNot available

org.apache.shale.test.mock.MockRequestMap

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockRequestMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR188

org.apache.shale.test.mock.MockServletContext

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockServletContext.getResourceAsStream(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caughtSTYLEREC_CATCH_EXCEPTION263
Method org.apache.shale.test.mock.MockServletContext.getResourcePaths(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION303

org.apache.shale.test.mock.MockSessionMap

BugCategoryDetailsLine
Method org.apache.shale.test.mock.MockSessionMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR189

org.apache.shale.test.mock.MockValueBinding

BugCategoryDetailsLine
org.apache.shale.test.mock.MockValueBinding.application is transient but org.apache.shale.test.mock.MockValueBinding isn't SerializableSTYLESE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASSNot available