The following document contains the results of FindBugs Report
FindBugs Version is 1.1.1
Threshold is Low
Effort is Default
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
405 | 28 | 30 | 73 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.shale.test.base.AbstractJsfTestCase.setUp() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 100 |
Bug | Category | Details | Line |
---|---|---|---|
Field not initialized in constructor: org.apache.shale.test.cargo.CargoTestSetup.container | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to fcontext in method org.apache.shale.test.el.FacesImplicitObjectELResolver.getFeatureDescriptors(javax.el.ELContext,Object) | STYLE | DLS_DEAD_LOCAL_STORE | 99 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.getType(javax.el.ELContext,Object,Object) | STYLE | DLS_DEAD_LOCAL_STORE | 86 |
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.getValue(javax.el.ELContext,Object,Object) | STYLE | DLS_DEAD_LOCAL_STORE | 127 |
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.isReadOnly(javax.el.ELContext,Object,Object) | STYLE | DLS_DEAD_LOCAL_STORE | 167 |
Dead store to elContext in method org.apache.shale.test.el.FacesPropertyResolverChainWrapper.setValue(javax.el.ELContext,Object,Object,Object) | STYLE | DLS_DEAD_LOCAL_STORE | 209 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to value in method org.apache.shale.test.el.FacesResourceBundleELResolver.getFeatureDescriptors(javax.el.ELContext,Object) | STYLE | DLS_DEAD_LOCAL_STORE | 84 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to econtext in method org.apache.shale.test.el.FacesVariableResolverChainWrapper.getValue(javax.el.ELContext,Object,Object) | STYLE | DLS_DEAD_LOCAL_STORE | 106 |
Dead store to elContext in method org.apache.shale.test.el.FacesVariableResolverChainWrapper.getValue(javax.el.ELContext,Object,Object) | STYLE | DLS_DEAD_LOCAL_STORE | 110 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.shale.test.el.MockMethodExpression.MockMethodExpression(String,Class[],Class) may expose internal representation by storing an externally mutable object into org.apache.shale.test.el.MockMethodExpression.signature | MALICIOUS_CODE | EI_EXPOSE_REP2 | 58 |
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockMethodExpression.equals(Object) | CORRECTNESS | NS_NON_SHORT_CIRCUIT | 103 |
Bug | Category | Details | Line |
---|---|---|---|
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockValueExpression.equals(Object) | CORRECTNESS | NS_NON_SHORT_CIRCUIT | 98 |
Bug | Category | Details | Line |
---|---|---|---|
Questionable use of non-short-circuit logic in org.apache.shale.test.el.MockVariableValueExpression.equals(Object) | CORRECTNESS | NS_NON_SHORT_CIRCUIT | 83 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.shale.test.jmock.AbstractJmockJsfTestCase.setUp() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 93 |
Bug | Category | Details | Line |
---|---|---|---|
Load of known null value in org.apache.shale.test.mock.MockApplication12.addELResolver(javax.el.ELResolver) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 154 |
Bug | Category | Details | Line |
---|---|---|---|
Method org.apache.shale.test.mock.MockApplicationMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 186 |
Bug | Category | Details | Line |
---|---|---|---|
Should org.apache.shale.test.mock.MockExternalContext$LocalesIterator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Unread field: org.apache.shale.test.mock.MockFacesContext.lifecycle | PERFORMANCE | URF_UNREAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.shale.test.mock.MockMethodBinding.MockMethodBinding(javax.faces.application.Application,String,Class[]) may expose internal representation by storing an externally mutable object into org.apache.shale.test.mock.MockMethodBinding.args | MALICIOUS_CODE | EI_EXPOSE_REP2 | 67 |
Comparison of String objects using == or != in org.apache.shale.test.mock.MockMethodBinding.equals(Object) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 201 |
Unread field: org.apache.shale.test.mock.MockMethodBinding.application | PERFORMANCE | URF_UNREAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
The class org.apache.shale.test.mock.MockRenderKit$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Method org.apache.shale.test.mock.MockRequestMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 188 |
Bug | Category | Details | Line |
---|---|---|---|
Method org.apache.shale.test.mock.MockServletContext.getResourceAsStream(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 263 |
Method org.apache.shale.test.mock.MockServletContext.getResourcePaths(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 303 |
Bug | Category | Details | Line |
---|---|---|---|
Method org.apache.shale.test.mock.MockSessionMap.putAll(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 189 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.shale.test.mock.MockValueBinding.application is transient but org.apache.shale.test.mock.MockValueBinding isn't Serializable | STYLE | SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS | Not available |