Checkstyle Results
The following document contains the results of Checkstyle. 
Summary
| Files | Infos  | Warnings  | Errors  |
|---|
| 58 | 0 | 0 | 336 |
Rules
| Rules | Violations | Severity |
|---|
| PackageHtml | 5 | Error |
| NewlineAtEndOfFile | 35 | Error |
| Translation | 0 | Error |
JavadocMethod- allowUndeclaredRTE: "true"
| 118 | Error |
| JavadocType | 0 | Error |
| JavadocVariable | 102 | Error |
| JavadocStyle | 4 | Error |
| ConstantName | 0 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 0 | Error |
| MemberName | 0 | Error |
| MethodName | 0 | Error |
| PackageName | 0 | Error |
| ParameterName | 0 | Error |
| StaticVariableName | 0 | Error |
| TypeName | 0 | Error |
RegexpHeader- header
1: /\*\s*
2: \*\s*Licensed to the Apache Software Foundation \(ASF\) under one or more
3: \*\s*contributor license agreements. See the NOTICE file distributed with
4: \*\s*this work for additional information regarding copyright ownership\.
5: \*\s*The ASF licenses this file to you under the Apache License, Version 2\.0
6: \*\s*\(the .License.\); you may not use this file except in compliance with
7: \*\s*the License. You may obtain a copy of the License at
8: \*\s*
9: \*\s*http://www\.apache\.org/licenses/LICENSE\-2\.0
10: \*\s*
11: \*\s*Unless required by applicable law or agreed to in writing, software
12: \*\s*distributed under the License is distributed on an .AS IS. BASIS,
13: \*\s*WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.
14: \*\s*See the License for the specific language governing permissions and
15: \*\s*limitations under the License\.
16: \*
| 0 | Error |
| AvoidStarImport | 0 | Error |
| IllegalImport | 0 | Error |
| RedundantImport | 0 | Error |
| UnusedImports | 0 | Error |
| FileLength | 0 | Error |
LineLength- ignorePattern: "^ \* @version .*$"
- max: "120"
| 1 | Error |
| MethodLength | 0 | Error |
| ParameterNumber | 1 | Error |
| EmptyForIteratorPad | 0 | Error |
NoWhitespaceAfter- tokens: "BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"
| 0 | Error |
| NoWhitespaceBefore | 0 | Error |
| OperatorWrap | 0 | Error |
| ParenPad | 0 | Error |
| TypecastParenPad | 0 | Error |
| TabCharacter | 0 | Error |
| WhitespaceAfter | 0 | Error |
| WhitespaceAround | 1 | Error |
| ModifierOrder | 0 | Error |
| RedundantModifier | 0 | Error |
| AvoidNestedBlocks | 0 | Error |
| EmptyBlock | 0 | Error |
| LeftCurly | 0 | Error |
| NeedBraces | 0 | Error |
| RightCurly | 0 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyStatement | 1 | Error |
| EqualsHashCode | 0 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 0 | Error |
| MagicNumber | 12 | Error |
| MissingSwitchDefault | 0 | Error |
| RedundantThrows | 28 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| FinalClass | 0 | Error |
| HideUtilityClassConstructor | 0 | Error |
| InterfaceIsType | 0 | Error |
| VisibilityModifier | 0 | Error |
| ArrayTypeStyle | 3 | Error |
GenericIllegalRegexp- message: "Line has trailing spaces."
- format: "\s+$"
| 25 | Error |
| TodoComment | 0 | Error |
| UpperEll | 0 | Error |
Details
org/apache/shale/test/el/FacesPropertyResolverChainWrapper.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Line has trailing spaces. | 37 |
| Expected an @return tag. | 43 |
| Expected @param tag for 'context'. | 43 |
| Expected @param tag for 'base'. | 43 |
| Expected an @return tag. | 61 |
| Expected an @return tag. | 78 |
| Expected an @return tag. | 119 |
| Expected an @return tag. | 159 |
org/apache/shale/test/mock/MockFacesContextFactory.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Redundant throws: 'FacesException' is unchecked exception. | 126 |
org/apache/shale/test/mock/MockServletOutputStream.java
| Violation | Message | Line |
|---|
| Expected an @return tag. | 51 |
| Expected an @return tag. | 68 |
org/apache/shale/test/el/MockVariableMapper.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 32 |
| First sentence should end with a period. | 37 |
| Line has trailing spaces. | 40 |
org/apache/shale/test/mock/MockLifecycleFactory.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
org/apache/shale/test/mock/package.html
| Violation | Message | Line |
|---|
| Missing package documentation file. | 0 |
org/apache/shale/test/mock/MockRenderKitFactory.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
org/apache/shale/test/mock/MockRenderKit.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
org/apache/shale/test/mock/MockPrintWriter.java
| Violation | Message | Line |
|---|
| Expected an @return tag. | 53 |
| Expected an @return tag. | 70 |
org/apache/shale/test/el/MockMethodExpression.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 34 |
| Expected an @return tag. | 101 |
| Expected an @return tag. | 116 |
| Expected an @return tag. | 126 |
| Expected an @return tag. | 137 |
| Expected an @return tag. | 153 |
| Expected an @return tag. | 170 |
| '=' is not preceded with whitespace. | 217 |
org/apache/shale/test/htmlunit/package.html
| Violation | Message | Line |
|---|
| Missing package documentation file. | 0 |
org/apache/shale/test/mock/MockHttpServletResponse.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected an @return tag. | 63 |
| Expected an @return tag. | 79 |
| Expected an @return tag. | 87 |
| Missing a Javadoc comment. | 123 |
| Missing a Javadoc comment. | 124 |
| Missing a Javadoc comment. | 125 |
| Missing a Javadoc comment. | 126 |
| Missing a Javadoc comment. | 127 |
| Missing a Javadoc comment. | 128 |
| Missing a Javadoc comment. | 129 |
| Expected an @return tag. | 431 |
org/apache/shale/test/cargo/package.html
| Violation | Message | Line |
|---|
| Missing package documentation file. | 0 |
org/apache/shale/test/mock/MockApplication.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 114 |
| Missing a Javadoc comment. | 115 |
| Missing a Javadoc comment. | 116 |
| Missing a Javadoc comment. | 117 |
| Missing a Javadoc comment. | 118 |
| Missing a Javadoc comment. | 119 |
| Missing a Javadoc comment. | 120 |
| Missing a Javadoc comment. | 121 |
| Missing a Javadoc comment. | 122 |
| Missing a Javadoc comment. | 123 |
| Missing a Javadoc comment. | 124 |
| Missing a Javadoc comment. | 125 |
| Missing a Javadoc comment. | 126 |
| Missing a Javadoc comment. | 127 |
| Redundant throws: 'FacesException' is unchecked exception. | 320 |
org/apache/shale/test/mock/MockHttpServletRequest.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 57 |
| Missing a Javadoc comment. | 64 |
| Missing a Javadoc comment. | 72 |
| Missing a Javadoc comment. | 82 |
| Expected an @return tag. | 172 |
| Missing a Javadoc comment. | 249 |
| Missing a Javadoc comment. | 250 |
| Missing a Javadoc comment. | 251 |
| Missing a Javadoc comment. | 252 |
| Missing a Javadoc comment. | 253 |
| Missing a Javadoc comment. | 254 |
| Missing a Javadoc comment. | 255 |
| Missing a Javadoc comment. | 256 |
| Missing a Javadoc comment. | 257 |
| Missing a Javadoc comment. | 258 |
| Missing a Javadoc comment. | 259 |
| Missing a Javadoc comment. | 260 |
| '46123' is a magic number. | 705 |
| '8080' is a magic number. | 737 |
| Expected an @return tag. | 874 |
| Expected an @return tag. | 884 |
org/apache/shale/test/mock/MockPropertyResolver.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Redundant throws: 'EvaluationException' is unchecked exception. | 60 |
| Redundant throws: 'PropertyNotFoundException' is subclass of 'EvaluationException'. | 60 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 60 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 83 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 92 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 116 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 125 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 142 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 151 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 173 |
| Expected an @return tag. | 195 |
org/apache/shale/test/el/FacesVariableResolverChainWrapper.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Line has trailing spaces. | 37 |
| Expected an @return tag. | 43 |
| Expected @param tag for 'context'. | 43 |
| Expected @param tag for 'base'. | 43 |
| Expected an @return tag. | 61 |
| Expected an @return tag. | 77 |
| Expected an @return tag. | 96 |
| Expected an @return tag. | 130 |
org/apache/shale/test/mock/MockEnumeration.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
org/apache/shale/test/mock/MockNavigationHandler.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected an @return tag. | 103 |
org/apache/shale/test/jmock/AbstractJmockJsfTestCase.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 80 |
| Missing a Javadoc comment. | 89 |
| Line has trailing spaces. | 90 |
| Line has trailing spaces. | 95 |
| Line has trailing spaces. | 104 |
| Line has trailing spaces. | 115 |
| Line has trailing spaces. | 142 |
| Missing a Javadoc comment. | 146 |
| Missing a Javadoc comment. | 172 |
| Missing a Javadoc comment. | 173 |
| Missing a Javadoc comment. | 174 |
| Missing a Javadoc comment. | 175 |
| Missing a Javadoc comment. | 176 |
| Missing a Javadoc comment. | 177 |
| Missing a Javadoc comment. | 178 |
| Missing a Javadoc comment. | 179 |
| Missing a Javadoc comment. | 180 |
| Missing a Javadoc comment. | 181 |
| Missing a Javadoc comment. | 182 |
| Missing a Javadoc comment. | 183 |
| Missing a Javadoc comment. | 186 |
org/apache/shale/test/el/FacesScopedAttributeELResolver.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Line has trailing spaces. | 40 |
| Expected an @return tag. | 46 |
| Expected @param tag for 'context'. | 46 |
| Expected @param tag for 'base'. | 46 |
| Expected an @return tag. | 64 |
| Expected an @return tag. | 128 |
| Expected an @return tag. | 151 |
| Expected an @return tag. | 192 |
org/apache/shale/test/mock/MockServlet.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected @throws tag for 'ServletException'. | 52 |
org/apache/shale/test/mock/MockApplicationMap.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected an @return tag. | 235 |
org/apache/shale/test/base/AbstractViewControllerTestCase.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
org/apache/shale/test/mock/MockFacesContext.java
| Violation | Message | Line |
|---|
| Missing a Javadoc comment. | 52 |
| Missing a Javadoc comment. | 58 |
| Missing a Javadoc comment. | 64 |
| Missing a Javadoc comment. | 112 |
| Missing a Javadoc comment. | 113 |
| Missing a Javadoc comment. | 114 |
| Missing a Javadoc comment. | 115 |
| Missing a Javadoc comment. | 116 |
| Missing a Javadoc comment. | 117 |
| Missing a Javadoc comment. | 118 |
| Missing a Javadoc comment. | 119 |
| Missing a Javadoc comment. | 120 |
org/apache/shale/test/mock/MockExternalContext.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 78 |
| Missing a Javadoc comment. | 79 |
| Missing a Javadoc comment. | 80 |
| Missing a Javadoc comment. | 81 |
| Missing a Javadoc comment. | 82 |
| Missing a Javadoc comment. | 83 |
| Missing a Javadoc comment. | 84 |
| Missing a Javadoc comment. | 85 |
| Redundant throws: 'FacesException' is unchecked exception. | 137 |
org/apache/shale/test/mock/MockLifecycle.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Redundant throws: 'FacesException' is unchecked exception. | 60 |
| Redundant throws: 'FacesException' is unchecked exception. | 84 |
org/apache/shale/test/mock/MockViewHandler.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
org/apache/shale/test/mock/MockHttpSession.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 97 |
| Missing a Javadoc comment. | 98 |
| Missing a Javadoc comment. | 99 |
| Missing a Javadoc comment. | 100 |
org/apache/shale/test/mock/MockServletConfig.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 87 |
| Missing a Javadoc comment. | 88 |
org/apache/shale/test/mock/MockExternalContext12.java
| Violation | Message | Line |
|---|
| Missing a Javadoc comment. | 40 |
org/apache/shale/test/mock/MockRequestMap.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected an @return tag. | 240 |
org/apache/shale/test/el/MockFunctionMapper.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 32 |
| First sentence should end with a period. | 37 |
| Line has trailing spaces. | 40 |
| Expected @param tag for 'prefix'. | 59 |
| Expected @param tag for 'localName'. | 59 |
| Expected @param tag for 'method'. | 59 |
org/apache/shale/test/el/MockValueExpression.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 37 |
| Expected an @return tag. | 96 |
| Expected an @return tag. | 111 |
| Expected an @return tag. | 121 |
| Expected an @return tag. | 132 |
| Expected an @return tag. | 146 |
| Expected an @return tag. | 160 |
| Expected an @return tag. | 181 |
| Expected an @return tag. | 208 |
| Line has trailing spaces. | 267 |
| Line is longer than 120 characters. | 269 |
org/apache/shale/test/base/package.html
| Violation | Message | Line |
|---|
| Missing package documentation file. | 0 |
org/apache/shale/test/mock/MockValueBinding.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected an @return tag. | 81 |
| Redundant throws: 'EvaluationException' is unchecked exception. | 108 |
| Redundant throws: 'PropertyNotFoundException' is subclass of 'EvaluationException'. | 108 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 108 |
| Redundant throws: 'EvaluationException' is unchecked exception. | 137 |
| Redundant throws: 'PropertyNotFoundException' is subclass of 'EvaluationException'. | 137 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 137 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 189 |
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. | 218 |
| Expected an @return tag. | 302 |
| Expected an @return tag. | 315 |
| Expected an @return tag. | 327 |
org/apache/shale/test/el/MockVariableValueExpression.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 29 |
| Expected an @return tag. | 81 |
| Expected an @return tag. | 96 |
| Expected an @return tag. | 106 |
| Expected an @return tag. | 117 |
| Expected an @return tag. | 131 |
| Expected an @return tag. | 145 |
| Expected an @return tag. | 161 |
| Expected an @return tag. | 179 |
org/apache/shale/test/base/AbstractJsfTestCase.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected @throws tag for 'Exception'. | 96 |
| Expected @throws tag for 'Exception'. | 156 |
| Missing a Javadoc comment. | 182 |
| Missing a Javadoc comment. | 183 |
| Missing a Javadoc comment. | 184 |
| Missing a Javadoc comment. | 185 |
| Missing a Javadoc comment. | 186 |
| Missing a Javadoc comment. | 187 |
| Missing a Javadoc comment. | 188 |
| Missing a Javadoc comment. | 189 |
| Missing a Javadoc comment. | 190 |
| Missing a Javadoc comment. | 191 |
| Missing a Javadoc comment. | 192 |
| Missing a Javadoc comment. | 193 |
| Missing a Javadoc comment. | 196 |
org/apache/shale/test/htmlunit/AbstractHtmlUnitTestCase.java
| Violation | Message | Line |
|---|
| Expected an @return tag. | 110 |
| Expected @throws tag for 'Exception'. | 120 |
| Expected an @return tag. | 139 |
| Expected an @return tag. | 162 |
| Expected an @return tag. | 182 |
| Expected an @return tag. | 202 |
| Expected an @return tag. | 225 |
| Expected an @return tag. | 237 |
| Expected an @return tag. | 255 |
| Expected an @return tag. | 287 |
| Expected an @return tag. | 302 |
| Expected an @return tag. | 319 |
org/apache/shale/test/mock/MockApplication12.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 58 |
| Expected an @return tag. | 129 |
| Redundant throws: 'ELException' is unchecked exception. | 183 |
org/apache/shale/test/mock/MockStateManager.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
org/apache/shale/test/mock/MockFacesContext12.java
| Violation | Message | Line |
|---|
| Missing a Javadoc comment. | 43 |
| Missing a Javadoc comment. | 49 |
| Missing a Javadoc comment. | 54 |
| Missing a Javadoc comment. | 77 |
org/apache/shale/test/mock/MockVariableResolver.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected an @return tag. | 126 |
org/apache/shale/test/el/FacesResourceBundleELResolver.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Line has trailing spaces. | 41 |
| Expected an @return tag. | 47 |
| Expected @param tag for 'context'. | 47 |
| Expected @param tag for 'base'. | 47 |
| Expected an @return tag. | 65 |
| Expected an @return tag. | 104 |
| Expected an @return tag. | 133 |
| Expected an @return tag. | 162 |
org/apache/shale/test/mock/MockMethodBinding.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 88 |
| Missing a Javadoc comment. | 89 |
| Array brackets at illegal position. | 89 |
| Missing a Javadoc comment. | 90 |
| Missing a Javadoc comment. | 91 |
| Missing a Javadoc comment. | 92 |
| Redundant throws: 'EvaluationException' is unchecked exception. | 100 |
| Redundant throws: 'MethodNotFoundException' is subclass of 'EvaluationException'. | 100 |
| Redundant throws: 'MethodNotFoundException' is unchecked exception. | 100 |
| Array brackets at illegal position. | 146 |
| '4' is a magic number. | 146 |
| '3' is a magic number. | 150 |
| Array brackets at illegal position. | 157 |
| Line has trailing spaces. | 160 |
| '3' is a magic number. | 162 |
| Expected an @return tag. | 236 |
org/apache/shale/test/mock/MockServletContext.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 111 |
| Missing a Javadoc comment. | 112 |
| Missing a Javadoc comment. | 113 |
| Missing a Javadoc comment. | 114 |
| Missing a Javadoc comment. | 115 |
| '4' is a magic number. | 192 |
| Empty statement. | 264 |
org/apache/shale/test/el/AbstractELResolver.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Line has trailing spaces. | 27 |
| Expected an @return tag. | 47 |
| More than 7 parameters. | 47 |
org/apache/shale/test/mock/MockResponseWriter.java
| Violation | Message | Line |
|---|
| Missing a Javadoc comment. | 51 |
| Missing a Javadoc comment. | 52 |
| Missing a Javadoc comment. | 53 |
| Missing a Javadoc comment. | 54 |
| Expected an @return tag. | 63 |
| '0xff' is a magic number. | 245 |
| '0x22' is a magic number. | 248 |
| '0x26' is a magic number. | 250 |
| '0x27' is a magic number. | 252 |
| '0x3C' is a magic number. | 254 |
| '0X3E' is a magic number. | 256 |
| Expected an @return tag. | 346 |
org/apache/shale/test/el/MockELContext.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 36 |
| First sentence should end with a period. | 41 |
| Line has trailing spaces. | 44 |
| Missing a Javadoc comment. | 49 |
| Missing a Javadoc comment. | 50 |
| Missing a Javadoc comment. | 51 |
| Missing a Javadoc comment. | 52 |
| Missing a Javadoc comment. | 53 |
org/apache/shale/test/mock/MockSessionMap.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Expected an @return tag. | 241 |
org/apache/shale/test/mock/MockActionListener.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Redundant throws: 'AbortProcessingException' is unchecked exception. | 60 |
org/apache/shale/test/el/MockExpressionFactory.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 33 |
| First sentence should end with a period. | 38 |
| Line has trailing spaces. | 41 |
| Expected an @return tag. | 172 |
| Expected an @return tag. | 214 |
| Expected an @return tag. | 243 |
org/apache/shale/test/el/FacesImplicitObjectELResolver.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
| Line has trailing spaces. | 40 |
| Expected an @return tag. | 74 |
| Expected @param tag for 'context'. | 74 |
| Expected @param tag for 'base'. | 74 |
| Expected an @return tag. | 92 |
| Expected an @return tag. | 123 |
| Expected an @return tag. | 152 |
| Expected an @return tag. | 222 |
org/apache/shale/test/mock/MockApplicationFactory.java
| Violation | Message | Line |
|---|
| File does not end with a newline. | 0 |
org/apache/shale/test/jmock/package.html
| Violation | Message | Line |
|---|
| Missing package documentation file. | 0 |
