Checkstyle Results
The following document contains the results of Checkstyle. 
Summary
| Files | Infos  | Warnings  | Errors  |
|---|
| 23 | 0 | 0 | 57 |
Rules
| Rules | Violations | Severity |
|---|
| PackageHtml | 3 | Error |
| NewlineAtEndOfFile | 0 | Error |
| Translation | 0 | Error |
JavadocMethod- allowUndeclaredRTE: "true"
| 8 | Error |
| JavadocType | 0 | Error |
| JavadocVariable | 0 | Error |
| JavadocStyle | 0 | Error |
| ConstantName | 0 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 0 | Error |
| MemberName | 0 | Error |
| MethodName | 0 | Error |
| PackageName | 0 | Error |
| ParameterName | 0 | Error |
| StaticVariableName | 0 | Error |
| TypeName | 0 | Error |
RegexpHeader- header
1: /\*\s*
2: \*\s*Licensed to the Apache Software Foundation \(ASF\) under one or more
3: \*\s*contributor license agreements. See the NOTICE file distributed with
4: \*\s*this work for additional information regarding copyright ownership\.
5: \*\s*The ASF licenses this file to you under the Apache License, Version 2\.0
6: \*\s*\(the .License.\); you may not use this file except in compliance with
7: \*\s*the License. You may obtain a copy of the License at
8: \*\s*
9: \*\s*http://www\.apache\.org/licenses/LICENSE\-2\.0
10: \*\s*
11: \*\s*Unless required by applicable law or agreed to in writing, software
12: \*\s*distributed under the License is distributed on an .AS IS. BASIS,
13: \*\s*WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.
14: \*\s*See the License for the specific language governing permissions and
15: \*\s*limitations under the License\.
16: \*
| 0 | Error |
| AvoidStarImport | 0 | Error |
| IllegalImport | 0 | Error |
| RedundantImport | 0 | Error |
| UnusedImports | 2 | Error |
| FileLength | 0 | Error |
LineLength- ignorePattern: "^ \* @version .*$"
- max: "120"
| 1 | Error |
| MethodLength | 0 | Error |
| ParameterNumber | 0 | Error |
| EmptyForIteratorPad | 0 | Error |
NoWhitespaceAfter- tokens: "BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"
| 0 | Error |
| NoWhitespaceBefore | 0 | Error |
| OperatorWrap | 17 | Error |
| ParenPad | 0 | Error |
| TypecastParenPad | 0 | Error |
| TabCharacter | 0 | Error |
| WhitespaceAfter | 0 | Error |
| WhitespaceAround | 0 | Error |
| ModifierOrder | 0 | Error |
| RedundantModifier | 17 | Error |
| AvoidNestedBlocks | 0 | Error |
| EmptyBlock | 0 | Error |
| LeftCurly | 0 | Error |
| NeedBraces | 0 | Error |
| RightCurly | 0 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyStatement | 3 | Error |
| EqualsHashCode | 0 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 0 | Error |
| MagicNumber | 0 | Error |
| MissingSwitchDefault | 0 | Error |
| RedundantThrows | 3 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| FinalClass | 0 | Error |
| HideUtilityClassConstructor | 0 | Error |
| InterfaceIsType | 0 | Error |
| VisibilityModifier | 2 | Error |
| ArrayTypeStyle | 0 | Error |
GenericIllegalRegexp- message: "Line has trailing spaces."
- format: "\s+$"
| 1 | Error |
| TodoComment | 0 | Error |
| UpperEll | 0 | Error |
Details
org/apache/shale/dialog/basic/config/ActionStateImpl.java
| Violation | Message | Line |
|---|
| '+' should be on a new line. | 66 |
| '+' should be on a new line. | 67 |
| '+' should be on a new line. | 68 |
| '+' should be on a new line. | 69 |
org/apache/shale/dialog/basic/BasicDialogContext.java
| Violation | Message | Line |
|---|
| Line is longer than 120 characters. | 272 |
| Empty statement. | 326 |
| Expected an @return tag. | 610 |
| Expected an @return tag. | 731 |
| Empty statement. | 819 |
| Variable 'stateName' must be private and have accessor methods. | 839 |
| Variable 'stackDepth' must be private and have accessor methods. | 848 |
| Expected an @return tag. | 854 |
org/apache/shale/dialog/basic/model/State.java
| Violation | Message | Line |
|---|
| Redundant 'public' modifier. | 57 |
| Redundant 'public' modifier. | 66 |
| Redundant 'public' modifier. | 78 |
| Redundant 'public' modifier. | 91 |
org/apache/shale/dialog/basic/config/package.html
| Violation | Message | Line |
|---|
| Missing package documentation file. | 0 |
org/apache/shale/dialog/basic/config/ConfigurationParser.java
| Violation | Message | Line |
|---|
| Empty statement. | 180 |
org/apache/shale/dialog/basic/config/AbstractState.java
| Violation | Message | Line |
|---|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. | 127 |
org/apache/shale/dialog/basic/config/DialogImpl.java
| Violation | Message | Line |
|---|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. | 203 |
| Redundant throws: 'IllegalArgumentException' is unchecked exception. | 225 |
| Unused @throws tag for 'Exception'. | 253 |
org/apache/shale/dialog/basic/model/package.html
| Violation | Message | Line |
|---|
| Missing package documentation file. | 0 |
org/apache/shale/dialog/basic/config/TransitionImpl.java
| Violation | Message | Line |
|---|
| '+' should be on a new line. | 81 |
org/apache/shale/dialog/basic/model/ActionState.java
| Violation | Message | Line |
|---|
| Redundant 'public' modifier. | 44 |
org/apache/shale/dialog/basic/config/EndStateImpl.java
| Violation | Message | Line |
|---|
| '+' should be on a new line. | 44 |
| '+' should be on a new line. | 45 |
| '+' should be on a new line. | 46 |
org/apache/shale/dialog/basic/package.html
| Violation | Message | Line |
|---|
| Missing package documentation file. | 0 |
org/apache/shale/dialog/basic/model/Dialog.java
| Violation | Message | Line |
|---|
| Redundant 'public' modifier. | 67 |
| Redundant 'public' modifier. | 75 |
| Redundant 'public' modifier. | 84 |
| Redundant 'public' modifier. | 95 |
| Redundant 'public' modifier. | 107 |
| Redundant 'public' modifier. | 120 |
| Redundant 'public' modifier. | 130 |
org/apache/shale/dialog/basic/model/Transition.java
| Violation | Message | Line |
|---|
| Redundant 'public' modifier. | 42 |
| Redundant 'public' modifier. | 51 |
org/apache/shale/dialog/basic/config/ViewStateImpl.java
| Violation | Message | Line |
|---|
| '+' should be on a new line. | 82 |
| '+' should be on a new line. | 83 |
| '+' should be on a new line. | 84 |
| '+' should be on a new line. | 85 |
org/apache/shale/dialog/basic/BasicDialogManager.java
| Violation | Message | Line |
|---|
| Unused import - org.apache.shale.dialog.DialogContextManager. | 30 |
| Expected an @return tag. | 127 |
| Expected @param tag for 'id'. | 127 |
| Expected @param tag for 'instance'. | 133 |
org/apache/shale/dialog/basic/model/ViewState.java
| Violation | Message | Line |
|---|
| Expected an @return tag. | 42 |
| Redundant 'public' modifier. | 42 |
| Redundant 'public' modifier. | 51 |
org/apache/shale/dialog/basic/Globals.java
| Violation | Message | Line |
|---|
| Unused import - org.apache.shale.dialog.basic.model.Dialog. | 20 |
org/apache/shale/dialog/basic/config/SubdialogStateImpl.java
| Violation | Message | Line |
|---|
| '+' should be on a new line. | 64 |
| '+' should be on a new line. | 65 |
| '+' should be on a new line. | 66 |
org/apache/shale/dialog/basic/BasicLifecycleListener.java
| Violation | Message | Line |
|---|
| Line has trailing spaces. | 40 |
| '+' should be on a new line. | 198 |
| '+' should be on a new line. | 199 |
org/apache/shale/dialog/basic/model/SubdialogState.java
| Violation | Message | Line |
|---|
| Redundant 'public' modifier. | 41 |
