The following document contains the results of FindBugs Report
FindBugs Version is 1.1.1
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 518 | 42 | 45 | 39 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Possible null pointer dereference of catalog in org.apache.shale.clay.component.Clay.encodeBegin(javax.faces.context.FacesContext) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 384 |
| Nullcheck of displayElement at line 306 of value previously dereferenced in org.apache.shale.clay.component.Clay.encodeBegin(javax.faces.context.FacesContext) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 305 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.clay.component.chain.CreateActionListenerCommand.execute(org.apache.commons.chain.Context) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 122 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.clay.component.chain.CreateComponentCommand.execute(org.apache.commons.chain.Context) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 165 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.clay.component.chain.CreateConverterCommand.execute(org.apache.commons.chain.Context) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 125 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.clay.component.chain.CreateValidatorCommand.execute(org.apache.commons.chain.Context) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 112 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.clay.component.chain.CreateValueChangeListenerCommand.execute(org.apache.commons.chain.Context) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 119 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Field not initialized in constructor: org.apache.shale.clay.config.ClayXmlParser.digester | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.clay.config.beans.Attributes.containsKey(Object) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 46 |
| Method org.apache.shale.clay.config.beans.Attributes.get(Object) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 63 |
| Method org.apache.shale.clay.config.beans.Attributes.put(Object,Object) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 82 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.clay.config.beans.ComponentConfigBean.NAMING_CONTAINER_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 1351 |
| org.apache.shale.clay.config.beans.ComponentConfigBean.messages isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 93 |
| Method call in org.apache.shale.clay.config.beans.ComponentConfigBean.unassignParent(ComponentBean) passes null for unconditionally dereferenced parameter of org.apache.shale.clay.config.beans.ComponentBean.addConverter(ConverterBean) | CORRECTNESS | NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS | 956 |
| org.apache.shale.clay.config.beans.ComponentConfigBean.context is transient but org.apache.shale.clay.config.beans.ComponentConfigBean isn't Serializable | STYLE | SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.clay.config.beans.ComponentConfigBean$WatchDog.WatchDog(ComponentConfigBean,ConfigBean$ConfigDefinition[],String) may expose internal representation by storing an externally mutable object into org.apache.shale.clay.config.beans.ComponentConfigBean$WatchDog.configDefs | MALICIOUS_CODE | EI_EXPOSE_REP2 | 1182 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.shale.clay.config.beans.ComponentConfigBean$XmlConfigDef be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Nullcheck of watchDog at line 123 of value previously dereferenced in org.apache.shale.clay.config.beans.TemplateComponentConfigBean.refresh(boolean) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 122 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Nullcheck of watchDog at line 186 of value previously dereferenced in org.apache.shale.clay.config.beans.TemplateConfigBean.refresh(boolean) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 185 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.clay.faces.ClayViewHandler.FORM_MARKERS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 315 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.shale.clay.parser.AttributeTokenizer$AttributeEntry be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class org.apache.shale.clay.parser.AttributeTokenizer$TokenIterator could be refactored into a _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class org.apache.shale.clay.parser.NodeTokenizer$TokenIterator could be refactored into a _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.clay.parser.Parser.BEGIN_CDATA_RULES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 587 |
| org.apache.shale.clay.parser.Parser.BEGIN_COMMENT_TAG_RULES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 608 |
| org.apache.shale.clay.parser.Parser.BEGIN_TAG_RULES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 630 |
| org.apache.shale.clay.parser.Parser.DOCTYPE_TAG_RULES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 623 |
| org.apache.shale.clay.parser.Parser.END_CDATA_RULES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 600 |
| org.apache.shale.clay.parser.Parser.END_COMMENT_TAG_RULES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 616 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.clay.parser.Parser$Attributes.add(java.util.Map$Entry) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 130 |
| Method org.apache.shale.clay.parser.Parser$Attributes.containsKey(Object) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 147 |
| Method org.apache.shale.clay.parser.Parser$Attributes.get(Object) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 92 |
| key could be null and is guaranteed to be dereferenced in org.apache.shale.clay.parser.Parser$Attributes.add(java.util.Map$Entry) | CORRECTNESS | NP_GUARANTEED_DEREF | 129 |
| Method call in org.apache.shale.clay.parser.Parser$Attributes.add(java.util.Map$Entry) passes null to a parameter declared @NonNull of java.util.TreeMap.put(Object,Object) | CORRECTNESS | NP_NONNULL_PARAM_VIOLATION | 133 |
| Class org.apache.shale.clay.parser.Parser$Attributes implements same interface as superclass. | STYLE | RI_REDUNDANT_INTERFACES | Not available |
| org.apache.shale.clay.parser.Parser$Attributes is serializable but also an inner class of a non-serializable class | BAD_PRACTICE | SE_BAD_FIELD_INNER_CLASS | Not available |
| Should org.apache.shale.clay.parser.Parser$Attributes be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.clay.parser.builder.Builder.messages isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 56 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.clay.parser.builder.VerbatimBuilder.encodeBegin(org.apache.shale.clay.parser.Node,org.apache.shale.clay.config.beans.ElementBean,org.apache.shale.clay.config.beans.ComponentBean) invokes toString() method on a String; just use the String | PERFORMANCE | DM_STRING_TOSTRING | 70 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.shale.clay.taglib.ClayTagValidator.validate(String,String,javax.servlet.jsp.tagext.PageData) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 184 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.clay.utils.ClayAmalgam$1.next() can't throw NoSuchElement exception | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 467 |
| The class org.apache.shale.clay.utils.ClayAmalgam$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |