The following document contains the results of FindBugs Report
FindBugs Version is 1.1.1
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 194 | 14 | 8 | 15 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.shale.usecases.rolodex.Contact.getSortName() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 169 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.usecases.rolodex.GenericComparator.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 48 |
| col2 could be null and is guaranteed to be dereferenced in org.apache.shale.usecases.rolodex.GenericComparator.compare(Object,Object) | CORRECTNESS | NP_GUARANTEED_DEREF | 142 |
| Possible null pointer dereference of col1 in org.apache.shale.usecases.rolodex.GenericComparator.compare(Object,Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 149 |
| org.apache.shale.usecases.rolodex.GenericComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.usecases.rolodex.HeaderSorter.saveState(javax.faces.context.FacesContext) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 80 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(javax.faces.context.FacesContext,javax.faces.component.UIData,HeaderSorter) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 122 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Questionable cast from Collection to abstract class java.util.SortedSet in org.apache.shale.usecases.rolodex.RolodexDao.findContactsForTab(int) | STYLE | BC_BAD_CAST_TO_ABSTRACT_COLLECTION | 153 |
| Questionable cast from java.util.Collection to java.util.TreeSet in org.apache.shale.usecases.rolodex.RolodexDao.findContact(String) | STYLE | BC_BAD_CAST_TO_CONCRETE_COLLECTION | 330 |
| org.apache.shale.usecases.rolodex.RolodexDao.TAB_INDEX should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 77 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Uncallable method org.apache.shale.usecases.rolodex.RolodexDao$1.addContact(Contact) defined in anonymous class | CORRECTNESS | UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS | 204-205 |
| Uncallable method org.apache.shale.usecases.rolodex.RolodexDao$1.addState(State) defined in anonymous class | CORRECTNESS | UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS | 183-201 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfo be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfoIterator.next() can't throw NoSuchElement exception | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 587-592 |