2009/05/20 - Apache Shale has been retired.

For more information, please explore the Attic.

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.1.1

Threshold is Low

Effort is Default

Summary

ClassesBugsErrorsMissing Classes
258101823

Files

ClassBugs
org.apache.shale.validator.CommonsValidator2
org.apache.shale.validator.faces.ValidatorScript2
org.apache.shale.validator.faces.ValidatorTag1
org.apache.shale.validator.faces.ValidatorViewHandler1
org.apache.shale.validator.util.ShaleValidatorAction3
org.apache.shale.validator.validator.AbstractValidator1

org.apache.shale.validator.CommonsValidator

BugCategoryDetailsLine
Confusing to have methods org.apache.shale.validator.CommonsValidator.setMinLength(String) and org.apache.shale.validator.faces.ValidatorTag.setMinlength(String)BAD_PRACTICENM_CONFUSING404
Non-virtual method call in org.apache.shale.validator.CommonsValidator.getErrorMessage(javax.faces.context.FacesContext,org.apache.commons.validator.ValidatorAction,java.util.Map) passes null for unconditionally dereferenced parameter of java.text.MessageFormat.MessageFormat(String,java.util.Locale)CORRECTNESSNP_NULL_PARAM_DEREF_NONVIRTUAL919

org.apache.shale.validator.faces.ValidatorScript

BugCategoryDetailsLine
Possible null pointer dereference of org.apache.shale.validator.faces.ValidatorScript.validatorVars in org.apache.shale.validator.faces.ValidatorScript.writeJavaScriptParams(javax.faces.context.ResponseWriter,javax.faces.context.FacesContext,String,org.apache.shale.validator.CommonsValidator)CORRECTNESSNP_NULL_ON_SOME_PATH556
Method org.apache.shale.validator.faces.ValidatorScript.writeValidationFunctions(javax.faces.context.ResponseWriter,javax.faces.context.FacesContext) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR396

org.apache.shale.validator.faces.ValidatorTag

BugCategoryDetailsLine
Confusing to have methods org.apache.shale.validator.faces.ValidatorTag.setMaxlength(String) and org.apache.shale.validator.CommonsValidator.setMaxLength(String)BAD_PRACTICENM_CONFUSING170-171

org.apache.shale.validator.faces.ValidatorViewHandler

BugCategoryDetailsLine
Unread field: org.apache.shale.validator.faces.ValidatorViewHandler.messagesPERFORMANCEURF_UNREAD_FIELDNot available

org.apache.shale.validator.util.ShaleValidatorAction

BugCategoryDetailsLine
org.apache.shale.validator.util.ShaleValidatorAction.getMessageArgs() may expose internal representation by returning org.apache.shale.validator.util.ShaleValidatorAction.messageArgsMALICIOUS_CODEEI_EXPOSE_REP186
org.apache.shale.validator.util.ShaleValidatorAction.getParameterArgs() may expose internal representation by returning org.apache.shale.validator.util.ShaleValidatorAction.parameterArgsMALICIOUS_CODEEI_EXPOSE_REP213
org.apache.shale.validator.util.ShaleValidatorAction.getSignature() may expose internal representation by returning org.apache.shale.validator.util.ShaleValidatorAction.signatureMALICIOUS_CODEEI_EXPOSE_REP222

org.apache.shale.validator.validator.AbstractValidator

BugCategoryDetailsLine
Possible null pointer dereference of result in org.apache.shale.validator.validator.AbstractValidator.validate(javax.faces.context.FacesContext,javax.faces.component.UIComponent,Object,String,java.util.Map) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION293